m1a2st commented on code in PR #20899:
URL: https://github.com/apache/kafka/pull/20899#discussion_r2541558319


##########
tests/docker/Dockerfile:
##########
@@ -155,4 +155,6 @@ RUN useradd -u $UID -ms /bin/bash ducker \
 
 USER ducker
 
+# Use tini as PID 1 to properly reap zombie processes and forward signals
+ENTRYPOINT ["/usr/bin/tini", "--"]

Review Comment:
   Test Results:
   ```
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         272 minutes 3.356 seconds
   tests run:        117
   passed:           117
   flaky:            0
   failed:           0
   ignored:          0
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         269 minutes 31.719 seconds
   tests run:        117
   passed:           114
   flaky:            0
   failed:           2
   ignored:          1
   
----------------------------------------------------------------------------------------------------
   test_id:    
kafkatest.tests.connect.connect_distributed_test.ConnectDistributedTest.test_broker_compatibility.broker_version=2.1.1.auto_create_topics=False.exactly_once_source=False.connect_protocol=eager.metadata_quorum=ZK
   status:     FAIL
   run time:   2 minutes 2.627 seconds
   
   
       TimeoutError('Data added to input file was not seen in the output file 
in a reasonable amount of time.')
   Traceback (most recent call last):
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
351, in _do_run
       data = self.run_test()
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.10/dist-packages/ducktape/mark/_mark.py", 
line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File 
"/opt/kafka-dev/tests/kafkatest/tests/connect/connect_distributed_test.py", 
line 973, in test_broker_compatibility
       wait_until(lambda: self._validate_file_output(self.FIRST_INPUT_LIST), 
timeout_sec=70, err_msg="Data added to input file was not seen in the output 
file in a reasonable amount of time.")
     File "/usr/local/lib/python3.10/dist-packages/ducktape/utils/util.py", 
line 58, in wait_until
       raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from 
last_exception
   ducktape.errors.TimeoutError: Data added to input file was not seen in the 
output file in a reasonable amount of time.
   
----------------------------------------------------------------------------------------------------
   test_id:    
kafkatest.tests.core.network_degrade_test.NetworkDegradeTest.test_rate.task_name=rate-1000-latency-50.device_name=eth0.latency_ms=50.rate_limit_kbit=1000000.metadata_quorum=COMBINED_KRAFT
   status:     FAIL
   run time:   59.436 seconds
   
   
       AssertionError('Expected most of the measured rates to be within an 
order of magnitude of target 1000000. This means `tc` did not limit the 
bandwidth as expected.')
   Traceback (most recent call last):
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
351, in _do_run
       data = self.run_test()
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.10/dist-packages/ducktape/mark/_mark.py", 
line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File "/opt/kafka-dev/tests/kafkatest/tests/core/network_degrade_test.py", 
line 146, in test_rate
       assert len(acceptable_rates) > 5, msg
   AssertionError: Expected most of the measured rates to be within an order of 
magnitude of target 1000000. This means `tc` did not limit the bandwidth as 
expected.
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         269 minutes 36.940 seconds
   tests run:        117
   passed:           116
   flaky:            0
   failed:           0
   ignored:          1
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         253 minutes 28.852 seconds
   tests run:        117
   passed:           116
   flaky:            0
   failed:           1
   ignored:          0
   
----------------------------------------------------------------------------------------------------
   test_id:    
kafkatest.tests.connect.connect_distributed_test.ConnectDistributedTest.test_file_source_and_sink.security_protocol=PLAINTEXT.exactly_once_source=True.connect_protocol=compatible.metadata_quorum=ISOLATED_KRAFT.group_protocol=consumer
   status:     FAIL
   run time:   4 minutes 23.752 seconds
   
   
       TimeoutError('Sink output file never converged to the same state as the 
input file')
   Traceback (most recent call last):
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
351, in _do_run
       data = self.run_test()
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.10/dist-packages/ducktape/mark/_mark.py", 
line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File 
"/opt/kafka-dev/tests/kafkatest/tests/connect/connect_distributed_test.py", 
line 645, in test_file_source_and_sink
       wait_until(lambda: self._validate_file_output(self.FIRST_INPUT_LIST + 
self.SECOND_INPUT_LIST), timeout_sec=150, err_msg="Sink output file never 
converged to the same state as the input file")
     File "/usr/local/lib/python3.10/dist-packages/ducktape/utils/util.py", 
line 58, in wait_until
       raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from 
last_exception
   ducktape.errors.TimeoutError: Sink output file never converged to the same 
state as the input file
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         256 minutes 11.902 seconds
   tests run:        117
   passed:           115
   flaky:            0
   failed:           2
   ignored:          0
   
----------------------------------------------------------------------------------------------------
   test_id:    
kafkatest.tests.streams.streams_smoke_test.StreamsSmokeTest.test_streams.processing_guarantee=at_least_once.crash=True.metadata_quorum=COMBINED_KRAFT.group_protocol=classic
   status:     FAIL
   run time:   6 minutes 51.043 seconds
   
   
       TimeoutError("Never saw 'REBALANCING -> RUNNING' message 
ducker@ducker07")
   Traceback (most recent call last):
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
351, in _do_run
       data = self.run_test()
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.10/dist-packages/ducktape/mark/_mark.py", 
line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File "/opt/kafka-dev/tests/kafkatest/tests/streams/streams_smoke_test.py", 
line 61, in test_streams
       monitor1.wait_until('REBALANCING -> RUNNING',
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/cluster/remoteaccount.py", 
line 753, in wait_until
       return wait_until(lambda: self.acct.ssh("tail -c +%d %s | grep '%s'" % 
(self.offset + 1, self.log, pattern),
     File "/usr/local/lib/python3.10/dist-packages/ducktape/utils/util.py", 
line 58, in wait_until
       raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from 
last_exception
   ducktape.errors.TimeoutError: Never saw 'REBALANCING -> RUNNING' message 
ducker@ducker07
   
----------------------------------------------------------------------------------------------------
   test_id:    
kafkatest.tests.tools.replica_verification_test.ReplicaVerificationToolTest.test_replica_lags.metadata_quorum=ISOLATED_KRAFT
   status:     FAIL
   run time:   56.767 seconds
   
   
       TimeoutError('Timed out waiting to reach non-zero number of replica 
lags.')
   Traceback (most recent call last):
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
351, in _do_run
       data = self.run_test()
     File 
"/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 
411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.10/dist-packages/ducktape/mark/_mark.py", 
line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File 
"/opt/kafka-dev/tests/kafkatest/tests/tools/replica_verification_test.py", line 
93, in test_replica_lags
       wait_until(lambda: self.replica_verifier.get_lag_for_partition(TOPIC, 0) 
> 0, timeout_sec=10,
     File "/usr/local/lib/python3.10/dist-packages/ducktape/utils/util.py", 
line 58, in wait_until
       raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from 
last_exception
   ducktape.errors.TimeoutError: Timed out waiting to reach non-zero number of 
replica lags.
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         269 minutes 12.179 seconds
   tests run:        117
   passed:           117
   flaky:            0
   failed:           0
   ignored:          0
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         272 minutes 45.541 seconds
   tests run:        117
   passed:           117
   flaky:            0
   failed:           0
   ignored:          0
   
====================================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2025-11-19--001
   run time:         279 minutes 22.565 seconds
   tests run:        116
   passed:           116
   flaky:            0
   failed:           0
   ignored:          0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to