lucasbru commented on code in PR #22245:
URL: https://github.com/apache/kafka/pull/22245#discussion_r3272973238
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroupMember.java:
##########
@@ -324,6 +360,13 @@ public boolean isReconciledTo(int targetAssignmentEpoch) {
return state == MemberState.STABLE && memberEpoch ==
targetAssignmentEpoch;
}
+ /**
+ * @return True if the member is in the Unrevoked state.
+ */
+ public boolean isUnrevokedState() {
Review Comment:
this is only used in one place (streamsGroupStaticMemberGroupLeave).
Consumer doesn't have an equivalent accessor - it just inlines `state ==
MemberState.UNREVOKED_PARTITIONS` at all four of its call sites. Could we drop
the method and inline the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
