kkonstantine commented on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-632265994
@wj1918 thanks for opening a PR! I'd definitely recommend fleshing out the bugfix in a separate PR from the rest of the refactoring since the latter does not seem trivial. Additionally, w/r/t the refactoring, I'd suggest thinking whether it is essential. Keep in mind that this connector is available for demonstration purposes only and therefore it's maintenance is not very heavy. But, back to the first point, before reviewing any changes, it'd be good to have them in separate PRs, since that will significantly help - at least myself - to review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
