bdbyrne edited a comment on pull request #8717:
URL: https://github.com/apache/kafka/pull/8717#issuecomment-637016443


   > Thanks for the PR @bdbyrne, I'm curious why we don't consider fixing the 
`AdminZkClient#validateTopicConfig` thrown exception type, but fix its caller 
instead. And in fact we have two callers for that path as well, so maybe a more 
comprehensive fix is to fix AdminZkClient IIUC.
   
   Hi @abbccdda -- there is a fix for the `AdminZkClient` at 
https://github.com/apache/kafka/pull/8715. This PR can be seen as an 
alternative/supplement in the case that changing the exception has other 
ramifications. I'm fine with dropping this if you feel the other PR is better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to