hachikuji commented on a change in pull request #9482:
URL: https://github.com/apache/kafka/pull/9482#discussion_r510437477



##########
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##########
@@ -369,6 +379,17 @@ public void transitionToLeader(long epochStartOffset) 
throws IOException {
         if (!candidateState.isVoteGranted())
             throw new IllegalStateException("Cannot become leader without 
majority votes granted");
 
+        // Note that the leader does not retain the high watermark that was 
known
+        // in the previous state. The purpose of this is to protect the 
monotonicity

Review comment:
       It was intended to refer to the behavior of not retaining the high 
watermark from the previous sentence. I will attempt to clarify.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to