hachikuji commented on a change in pull request #9732:
URL: https://github.com/apache/kafka/pull/9732#discussion_r541225579
##########
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala
##########
@@ -164,13 +164,11 @@ class BrokerToControllerRequestThread(networkClient:
KafkaClient,
listenerName: ListenerName,
time: Time,
threadName: String)
- extends InterBrokerSendThread(threadName, networkClient, time,
isInterruptible = false) {
+ extends InterBrokerSendThread(threadName, networkClient,
config.controllerSocketTimeoutMs, time, isInterruptible = false) {
private var activeController: Option[Node] = None
- override def requestTimeoutMs: Int = config.controllerSocketTimeoutMs
-
- override def generateRequests(): Iterable[RequestAndCompletionHandler] = {
+ def generateRequests(): Iterable[RequestAndCompletionHandler] = {
Review comment:
Can you clarify what the option would achieve over an empty collection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
