ijuma commented on a change in pull request #9732:
URL: https://github.com/apache/kafka/pull/9732#discussion_r541378653
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java
##########
@@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffsetsToTxnRequestData
data, short version) {
}
@Override
- protected AddOffsetsToTxnRequestData data() {
+ public AddOffsetsToTxnRequestData data() {
Review comment:
I can see this:
1. AbstractRequest/AbstractResponse methods become part of the ApiMessage
hierarchy.
2. FooRequest/FooResponse extends FooDataRequest/FooDataResponse (like Colin
suggested before)
But I don't think you want to eliminate FooRequest/FooResponse in the
example above. You don't need to perform conversions for the inner classes, but
it's a place where you can normalize the representation. We do that for many of
the existing request/response classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
