d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-745712214
Thanks, @rajinisivaram for the review. According to the comments, I've 1. Support super user in Authorizer, AclAuthorizer, and AuthorizerWrapper. Add tests to the three corresponding testing classes. 2. Rename ResourceIndex to ResourceTypeKey, and make it an inner class of AclAuthorizer. 3. Cleaned the tear-off logic in the unit tests since ZK starts in setup() indeed. 4. Addressed other NIT suggestions. Please let me know if anything else needs to be changed, especially if the super user part looks good to you. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org