ableegoldman commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r553024443
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -128,6 +133,7 @@ public void shouldRemoveStreamThread() throws Exception {
final int oldThreadCount =
kafkaStreams.localThreadsMetadata().size();
assertThat(kafkaStreams.removeStreamThread().get().split("-")[0],
equalTo(appId));
assertThat(kafkaStreams.localThreadsMetadata().size(),
equalTo(oldThreadCount - 1));
+ waitForApplicationState(Collections.singletonList(kafkaStreams),
KafkaStreams.State.RUNNING, DEFAULT_DURATION);
Review comment:
Ah, sorry I didn't think of this/mention it before, but I think we
actually need to wait for a _transition_ to RUNNING, and not just for it to be
in the state itself. It probably takes a little while after removing a thread
for the rebalance to occur, so it's probably already in RUNNING. Pretty sure
there's some other integration test util that watches for the REBALANCING ->
RUNNING transition, though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
