ableegoldman commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r553078581
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -992,7 +992,7 @@ private StreamThread createStreamThread(final long
cacheSizePerThread, final int
if (isRunningOrRebalancing()) {
synchronized (changeThreadCount) {
for (final StreamThread streamThread : threads) {
- if (streamThread.isAlive()) {
+ if (streamThread.isAlive() &&
(!streamThread.getName().equals(Thread.currentThread().getName()) ||
threads.size() == 1)) {
Review comment:
Then why check `isAlive()` here at all? (I'm not necessarily requesting
changes here, just trying to understand)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
