ableegoldman commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r553079791
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -128,6 +133,7 @@ public void shouldRemoveStreamThread() throws Exception {
final int oldThreadCount =
kafkaStreams.localThreadsMetadata().size();
assertThat(kafkaStreams.removeStreamThread().get().split("-")[0],
equalTo(appId));
assertThat(kafkaStreams.localThreadsMetadata().size(),
equalTo(oldThreadCount - 1));
+ waitForApplicationState(Collections.singletonList(kafkaStreams),
KafkaStreams.State.RUNNING, DEFAULT_DURATION);
Review comment:
Cool, I think your plan to just `waitForApplicationState` on REBALANCING
before RUNNING sounds good. But I think you missed doing that here -- in fact
we should probably do a similar thing in all the tests in this class. Can you
just give the file a final pass and make sure we verify the REBALANCING ->
RUNNING transition in all of the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
