jsancio commented on a change in pull request #9756:
URL: https://github.com/apache/kafka/pull/9756#discussion_r555462779
##########
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##########
@@ -37,6 +37,7 @@
private final Time time;
private final SimpleTimer lingerTimer;
private final int lingerMs;
+ private final int minFlushSize;
Review comment:
> Say for example, that we have a hard-coded 1MB max batch size. Then we
could say that the effective batch size is equal to min(1MB, maxUnflushedSize)
Hmm. I am sure on the right behaviour here. You probably already discussed
this and I missed it but can you elaborate on why we want to have a minimum for
the maximum batch size?
Are you thinking that we need to have a maximum batch size that is at least
as large as the smallest record that the Kafka Controller can generate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
