hachikuji commented on a change in pull request #9756:
URL: https://github.com/apache/kafka/pull/9756#discussion_r556118897
##########
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##########
@@ -37,6 +37,7 @@
private final Time time;
private final SimpleTimer lingerTimer;
private final int lingerMs;
+ private final int minFlushSize;
Review comment:
It sounds like we are basically on the same page here. I think we agree
that there should be a configuration. As suggested in the other comment, I like
`quorum.append.max.unflushed.bytes` to go along with `quorum.append.linger.ms`.
Perhaps we could even use `quorum.append.max.linger.ms` to make it clear that
it is the maximum amount of time that the server will hold onto a write before
flushing.
In regard to the question of setting the batch size, I suggest we stick with
the hard-coded value for now and set the effective value to be the minimum of
the hard-coded value and `max.unflushed.bytes`. We can file a separate jira to
consider whether this should be configurable separately or whether we can allow
`max.unflushed.bytes` to specify the batch size precisely.
@vamossagar12 Does that sound reasonable to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
