hachikuji commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r557064046
##########
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##########
@@ -404,13 +404,47 @@ public ConfigDef define(String name, Type type,
Importance importance, String do
* @param name The name of the config parameter
* @param type The type of the config
* @param defaultValue The default value to use if this config isn't
present
- * @param importance
+ * @param importance The importance of this config (i.e. is this
something you will likely need to change?)
* @return This ConfigDef so you can chain calls
*/
public ConfigDef defineInternal(final String name, final Type type, final
Object defaultValue, final Importance importance) {
return define(new ConfigKey(name, type, defaultValue, null,
importance, "", "", -1, Width.NONE, name, Collections.<String>emptyList(),
null, true));
}
+ /**
+ * Define a new internal configuration. Internal configuration won't show
up in the docs and aren't
+ * intended for general use.
+ * @param name The name of the config parameter
+ * @param type The type of the config
+ * @param defaultValue The default value to use if this config isn't
present
+ * @param validator the validator to use in checking the correctness
of the config
+ * @param importance The importance of this config (i.e. is this
something you will likely need to change?)
+ * @return This ConfigDef so you can chain calls
+ */
+ public ConfigDef defineInternal(
+ final String name,
+ final Type type,
+ final Object defaultValue,
+ final Validator validator,
+ final Importance importance
+ ) {
+ return define(new ConfigKey(
+ name,
+ type,
+ defaultValue,
+ validator,
+ importance,
+ "",
+ "",
+ -1,
+ Width.NONE,
+ name,
+ Collections.<String>emptyList(),
+ null,
+ true
+ ));
+ }
Review comment:
Fair enough, I'll conform. I just find the other style hard to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
