tang7526 commented on a change in pull request #10012:
URL: https://github.com/apache/kafka/pull/10012#discussion_r569549005
##########
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredValidatorCallbackHandler.java
##########
@@ -170,33 +170,31 @@ private void handleCallback(OAuthBearerValidatorCallback
callback) {
.throwExceptionIfFailed();
OAuthBearerValidationUtils.validateTimeConsistency(unsecuredJwt).throwExceptionIfFailed();
OAuthBearerValidationUtils.validateScope(unsecuredJwt,
requiredScope).throwExceptionIfFailed();
- log.info("Successfully validated token with principal {}: {}",
unsecuredJwt.principalName(),
- unsecuredJwt.claims().toString());
+ if (log.isInfoEnabled()) {
Review comment:
OK, I think you are right. We do not need condition check in here. I
already revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
