ijuma commented on a change in pull request #10457:
URL: https://github.com/apache/kafka/pull/10457#discussion_r635194308
##########
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##########
@@ -229,13 +205,21 @@ object TopicCommand extends Logging {
Admin.create(commandConfig)
}
- def apply(commandConfig: Properties, bootstrapServer: Option[String]):
AdminClientTopicService =
- new AdminClientTopicService(createAdminClient(commandConfig,
bootstrapServer))
+ def apply(commandConfig: Properties, bootstrapServer: Option[String]):
TopicService =
+ new TopicService(createAdminClient(commandConfig, bootstrapServer))
}
- case class AdminClientTopicService private (adminClient: Admin) extends
TopicService {
+ case class TopicService private (adminClient: Admin) extends AutoCloseable {
Review comment:
This should not be a case class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
