mumrah commented on a change in pull request #10864:
URL: https://github.com/apache/kafka/pull/10864#discussion_r649482956
##########
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##########
@@ -294,19 +298,14 @@ final class KafkaMetadataLog private (
}
}
- override def deleteBeforeSnapshot(logStartSnapshotId: OffsetAndEpoch):
Boolean = {
+ override def deleteBeforeSnapshot(deleteBeforeSnapshotId: OffsetAndEpoch):
Boolean = {
Review comment:
Since this is no longer used to increase the Log Start Offset, I think
this method can go away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
