rondagostino commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376
LGTM > How is `metadata_quorum` used? `KafkaService` uses the value of `metadata_quorum` to determine what type of metadata quorum the test should use, and there are a bunch of things that have to happen if the value indicates co-located or remote KRaft (broker config changes, potentially creating/configuring/starting a remote controller quorum). The actual test code itself (`test_reassign_partitions()` in this case) doesn't use the value directly, but we have to declare the parameter in order to inject the value. `KafkaService` generally uses the injected value by invoking either: 1. `self.quorum_info = quorum.ServiceQuorumInfo(self, context)` to get the general quorum information for the service (whether it is using ZooKeeper, co-located KRaft, or remote KRaft) -- or -- 2. `quorum.NodeQuorumInfo(self.quorum_info, node)` to get the specific details for a particular node (i.e. what it's `broker.roles` value should be, since it is potentially different across the different nodes of a Kafka cluster when using co-located KRaft) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
