RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713800603
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -505,7 +497,7 @@ public boolean poll(Timer timer, boolean waitForJoinGroup) {
}
// if not wait for join group, we would just use a timer of 0
- if (!ensureActiveGroup(waitForJoinGroup ? timer :
time.timer(0L))) {
+ if (!ensureActiveGroup(waitForJoinGroup ? timer :
time.timer(0L), timer)) {
Review comment:
The second `timer` variable here is a customer-defined timer, which is
passed to the underlying `onJoinPrepare` method to replace the old timer
maybeAutoCommitOffsetsSync(**time.timer(rebalanceConfig.rebalanceTimeoutMs)**)
Expect to retry submitting offsets as much as possible within the timeout
period set by the user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
