RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r716168292
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1069,6 +1074,37 @@ private void maybeAutoCommitOffsetsSync(Timer timer) {
}
}
+ private void cleanUpConsumedOffsets(Map<TopicPartition, OffsetAndMetadata>
willCommitOffsets) {
+
+ if (willCommitOffsets.isEmpty())
+ return;
+
+ Set<String> validTopics = metadata.fetch().topics();
+ Set<TopicPartition> toGiveUpTopicPartitions = new HashSet<>();
+
+ Iterator<Map.Entry<TopicPartition, OffsetAndMetadata>> iterator =
willCommitOffsets.entrySet().iterator();
+
+ while (iterator.hasNext()) {
+
+ Map.Entry<TopicPartition, OffsetAndMetadata> entry =
iterator.next();
+
+ if (!validTopics.contains(entry.getKey().topic())) {
+
+ toGiveUpTopicPartitions.add(entry.getKey());
Review comment:
I think that we store` toGiveUpTopicPartitions` variable can let
customers know more clearly which topicPartitions will give up submitting
offsets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
