RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r719890048
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1069,6 +1075,37 @@ private void maybeAutoCommitOffsetsSync(Timer timer) {
}
}
+ private void cleanUpConsumedOffsets(Map<TopicPartition, OffsetAndMetadata>
partitionOffsetsToBeCommitted) {
+
+ if (partitionOffsetsToBeCommitted.isEmpty())
+ return;
+
+ Set<String> validTopics = metadata.fetch().topics();
+ Set<TopicPartition> toGiveUpTopicPartitions = new HashSet<>();
+
+ Iterator<TopicPartition> iterator =
partitionOffsetsToBeCommitted.keySet().iterator();
+
+ while (iterator.hasNext()) {
+
+ TopicPartition topicPartition = iterator.next();
+
+ if (!validTopics.contains(topicPartition.topic())) {
+
+ toGiveUpTopicPartitions.add(topicPartition);
+ iterator.remove();
+ }
+
+ }
+
+ if (toGiveUpTopicPartitions.size() > 0) {
+
+ //Because toGiveUpTopicPartitions may receive
`UnknownTopicOrPartitionException` when submitting their offsets.
+ //We are prepared to abandon them. The worst effect is that these
partitions may repeatedly consume some messages
Review comment:
I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
