hachikuji commented on a change in pull request #11004:
URL: https://github.com/apache/kafka/pull/11004#discussion_r750784403
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -1206,7 +1205,8 @@ private void validatePositionsOnMetadataChange() {
fetchable.put(node, builder);
}
- builder.add(partition,
topicIds.getOrDefault(partition.topic(), Uuid.ZERO_UUID), new
FetchRequest.PartitionData(position.offset,
+ Uuid topicId = metadata.topicId(partition.topic());
Review comment:
Apologies. I was being a bit slow here. I had not considered the
possibility of the id of a given topic changing while we were building the
fetch request. I had forgotten that the fetch builder logic does allow the same
topic to be included multiple times. It do agree that it is probably better to
not allow this. So reverting this change makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
