hachikuji commented on a change in pull request #11004:
URL: https://github.com/apache/kafka/pull/11004#discussion_r750820000



##########
File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java
##########
@@ -218,10 +218,10 @@ public synchronized boolean updateRequested() {
     }
 
     /**
-     * @return the topic ID for the given topic name or null if the ID does 
not exist or is not known
+     * @return a mapping from topic names to topic IDs for all topics with 
valid IDs in the cache
      */
-    public synchronized Uuid topicId(String topicName) {

Review comment:
       Any harm keeping this one? Seems like it simplified some of the uses, 
especially in tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to