showuon commented on pull request #11242: URL: https://github.com/apache/kafka/pull/11242#issuecomment-979793930
@guozhangwang , thanks for your comment. I finally got time to revisit this POC. Yes, I agree that this new state store config can be defined on the newly introduced `TopologyConfig`. I checked it again, and it'll work well with `TopologyConfig`. > I thought we would use a enum, as the KIP suggested in enum StoreType, instead of a StoreImplementation interface. Actually, the reason why we don't choose `enum` is because that only works for our built-in state stores, not for **custom state store**. So, with the `StoreImplementation` interface, user can implement their state stores their, and set as default stores if they want. I'll start to draft the KIP. Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
