showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795017377
##########
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##########
@@ -514,18 +635,21 @@ public void testMetadataFetch() throws
InterruptedException {
producer.close(Duration.ofMillis(0));
}
- @Test
- public void testMetadataExpiry() throws InterruptedException {
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testMetadataExpiry(boolean isIdempotenceEnabled) throws
InterruptedException {
Map<String, Object> configs = new HashMap<>();
configs.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999");
+ configs.put(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG,
isIdempotenceEnabled);
ProducerMetadata metadata = mock(ProducerMetadata.class);
Cluster emptyCluster = new Cluster(
"dummy",
- Collections.singletonList(host1),
+ Collections.singletonList(NODE),
Review comment:
Nice catch! Yes, we can remove the `emptyCluster` declaration here and
reuse the global one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
