[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

[GitBox]

bozhao12 commented on a change in pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#discussion_r835149333



##########
File path: core/src/test/scala/integration/kafka/server/DelayedFetchTest.scala
##########
@@ -166,6 +171,34 @@ class DelayedFetchTest {
     assertTrue(fetchResultOpt.isDefined)
   }
 
+
+  @Test
+  def testHasPreferredReadReplica(): Unit = {

Review comment:
       @dajac  Following your  suggestion, I have modified the unit test.
   I also found some problems when modifying the unit test, which I think it's 
a bug:
   If KafkaConfig.ReplicaSelectorClassProp is not configured, 
ReplicaManager.replicaSelectorOpt will  be a None object, which will cause most 
of the unit tests on preferred read replicas to not take test purpose., eg 
ReplicaManagerTest.testReplicaSelector.
   Should I mention another PR  or fix it in this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org