Bugs item #3469215, was opened at 2012-01-03 12:58
Message generated for change (Comment added) made by michaudm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=679906&aid=3469215&group_id=118054

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General / Other
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: michael michaud (michaudm)
Assigned to: michael michaud (michaudm)
Summary: Removing Layer while Attribute Table opened can freeze OJ

Initial Comment:
Load a layer with some attributes. 
Create several layers with Edit > Extract > Create a layer by attribute value 
Open the attribute table of one of the new layers
Remove the corresponding layer from LayerNamePanel
Change editability from the attribute panel.
You get an exception, and the UI starts freezing.

Stangely, I cannot reproduce the same sequence from new layers created from 
right click (I get the exception, but the UI does not freeze in this case).

Solution.
When a layer is removed from LayerNamePanel, I think one must check if an 
attibute panel or an info panel refers to this layer.
If true, the user should be asked to abandon the removal, or to close all the 
JInternalFrame refering to this layer.


----------------------------------------------------------------------

>Comment By: michael michaud (michaudm)
Date: 2012-01-04 14:41

Message:
Currently, the RemoveSelectedLayers plugin call the LayerManager dispose
method.
If the method fire a remove event (doesnt know if it already exists)
and if the AttributePanel listen to this event, 
I can see how a dialog box can prevent the AttributePanel to be closed, 
but I can't see how I will prevent the dispose method to finish its work
and remove the layer from the LayerNamePanel...
That said, I agree with you, we don't need this confirmation box.

----------------------------------------------------------------------

Comment By: ede (edso)
Date: 2012-01-04 14:01

Message:
of course can the Attribute showing plugin, when notified of a layer
deletion fire up a yes/no box. no problem there.

but i guess by deleting a layer the user will definitely not expect the
attributes anymore so i see no point for any dialog there.

ede

----------------------------------------------------------------------

Comment By: michael michaud (michaudm)
Date: 2012-01-04 13:53

Message:
Ede, this is a nice idea I had not considered.
I'm closed to a solution following my idea, but I will spend some time to
explore yours.
I think that a event-listener approach wouldn't be as interactive (no
question to the user, but automatic close of all dependencies), but this is
not a show-stopper.
If it's cleaner, it definitely is worthwhile.

As this is quite an annoying bug, maybe I'll commit my solution soon and
come back to discuss a better solution with you after.

----------------------------------------------------------------------

Comment By: ede (edso)
Date: 2012-01-04 02:23

Message:
Wouldn't it be more accurate to have AttributeTable's Plugin register to
listen for layer events like that and react accordingly?

..ede



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=679906&aid=3469215&group_id=118054

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to