yes, but it is "stupid" because

1. we have to add two entries. the one in the language files and the one in the 
interface (btw. that's not what interfaces are meant for)

2. we have two mechanisms then, static variables _and_ i18n. this means we 
start to mix I18N.getMessage() calls w/ GenericNames.SOMEVALUE

still, a candidate to deprecate instantly :(.. ede


On 22.03.2017 15:09, Giuseppe Aruta wrote:
> Using   com.vividsolutions.jump.workbench.ui.GenericNames we don't need even 
> to add new ui.Generics.<string>s to language/jump files.
> For instance,  "Attributes" string could be a new line into GenericsNames:
> 
>  public static String 
> ATTRIBUTES=I18N.get("org.openjump.core.ui.plugin.tools.generate.LinearReferencingOnLayerPlugIn.attributes");
> 
> 
> 2017-03-22 14:37 GMT+01:00 <edgar.sol...@web.de <mailto:edgar.sol...@web.de>>:
> 
>     found it
>       com.vividsolutions.jump.workbench.ui.GenericNames
>     is an Interface and uses the translations ui.GenericNames.* i mentioned 
> previously to Pepe.
> 
>     i don't feel we should continue this line of coding. it makes sense for a 
> very limited amount of fixed strings, like menu names, but not for a growing 
> number of often used words or phrases.
> 
>     ..ede
> 
> 
>     On 22.03.2017 14:27, edgar.sol...@web.de <mailto:edgar.sol...@web.de> 
> wrote:
>     > Stefan,
>     >
>     > what do you mean by class?
>     >   com.vividsolutions.jump.workbench.ui.MenuNames
>     > ? deals only with menu names.
>     >
>     >  ..ede
>     >
>     > On 22.03.2017 15:23, Stefan Steiniger wrote:
>     >> Hi Ede,
>     >>
>     >>
>     >>
>     >> we have a class for generic strings already - since the beginning, i 
> think.
>     >>
>     >>
>     >>
>     >> cheers,
>     >>
>     >> stefan
>     >>
>     >>
>     >>
>     >> ------ Originalnachricht ------
>     >> *Von: *
>     >> *Datum: *22.03.2017 6:11
>     >> *An: *OpenJump develop and use;
>     >> *Betreff:*Re: [JPP-Devel] SVN: [5392] 
> plug-ins/CADExtension/trunk/src/org/openjump/advancedtools
>     >>
>     >> On 21.03.2017 21:42, Michaël Michaud wrote:
>     >>> Hi,
>     >>>
>     >>> You're right, there are many duplicates (and I must admit I recognize 
> several plugins of mine).
>     >>>
>     >>> Removing all duplicates would be a very big effort.
>     >>
>     >> bad idea. we've got enough on our plates as it is.
>     >>
>     >>> But as a first step, we could add keys for common messages and 
> encourage people to use it for new plugins or to clean existing plugins when 
> they are revised.
>     >>
>     >> additionally we could relatively easy implement a key re-usage along 
> the lines of
>     >>
>     >> generic.layer=Layer
>     >> plugin.does.stuff.layer={generic.layer}
>     >>
>     >> ..ede
>     >>>
>     >>> Michaël
>     >>>
>     >>>
>     >>> Le 21/03/2017 à 20:26, Giuseppe Aruta a écrit :
>     >>>> Sorry Ede.
>     >>>>
>     >>>> Looking for "source" string, I just noted that in  OJ language files 
> we have some strings which look like duplicates:
>     >>>> for instance:
>     >>>> 
> org.openjump.core.ui.plugin.tools.JoinAttributesSpatiallyPlugIn.source-layer
>     >>>> org.openjump.core.ui.plugin.tools.MakeValidPlugIn.source-layer
>     >>>> org.openjump.core.ui.plugin.tools.RemoveSpikePlugIn.source-layer
>     >>>> 
> org.openjump.core.ui.plugin.tools.generate.LinearReferencingOnLayerPlugIn.source-layer
>     >>>> ui.plugin.analysis.DissolvePlugIn.source-layer
>     >>>> ui.warp.WarpingPanel.source-layer
>     >>>>
>     >>>> I wonder if they have been (or they must be)  translated in 
> different ways in some language.
>     >>>> best regards and thanks
>     >>>> Peppe
>     >>>>
>     >>>> 2017-03-21 20:01 GMT+01:00 >:
>     >>>>
>     >>>>     On 21.03.2017 19:39, Giuseppe Aruta wrote:
>     >>>>     > - Cadtools check codes: yes there must be already into Jump 
> language files:
>     >>>>     > yes there are. This is  what remains of a previous version of 
> Cad tools
>     >>>>     > (where I didn't use OJ check system). I did a clean up before 
> to add to
>     >>>>     > repository but I forgot to remove some codes. Hopefully I 
> wanted to do a
>     >>>>     > better clean up on next version: I was waiting somebody who 
> was helping me
>     >>>>     > to find them. Jus don't add them: I wil provide to clean 
> before next real.
>     >>>>     > comparing to german language file
>     >>>>
>     >>>>     too late.. ede
>     >>>>
>     >>>>     
> ------------------------------------------------------------------------------
>     >>>>     Check out the vibrant tech community on one of the world's most
>     >>>>     engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     >>>>     _______________________________________________
>     >>>>     Jump-pilot-devel mailing list
>     >>>>     Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     >>>>     https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
>     >>>>
>     >>>>
>     >>>>
>     >>>>
>     >>>> 
> ------------------------------------------------------------------------------
>     >>>> Check out the vibrant tech community on one of the world's most
>     >>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     >>>>
>     >>>>
>     >>>> _______________________________________________
>     >>>> Jump-pilot-devel mailing list
>     >>>> Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     >>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
>     >>>
>     >>>
>     >>>
>     >>> 
> ------------------------------------------------------------------------------
>     >>> Check out the vibrant tech community on one of the world's most
>     >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     >>>
>     >>>
>     >>>
>     >>> _______________________________________________
>     >>> Jump-pilot-devel mailing list
>     >>> Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
>     >>>
>     >>
>     >> 
> ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     >> _______________________________________________
>     >> Jump-pilot-devel mailing list
>     >> Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
>     >>
>     >>
>     >>
>     >> 
> ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> Jump-pilot-devel mailing list
>     >> Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
>     >>
>     >
>     > 
> ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > Jump-pilot-devel mailing list
>     > Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
>     >
> 
>     
> ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     _______________________________________________
>     Jump-pilot-devel mailing list
>     Jump-pilot-devel@lists.sourceforge.net 
> <mailto:Jump-pilot-devel@lists.sourceforge.net>
>     https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel 
> <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> 
> 
> 
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to