Inline again

envoyé : 16 janvier 2022 à 14:54
de : edgar.sol...@web.de
à : Michaud Michael <m.michael.mich...@orange.fr>, OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net>
objet : Re: [JPP-Devel] Fwd: [openjump-gis/openjump] ec1bf8: upgrade cadtools to 2.1.1


see inline

On 16.01.2022 14:21, Michaud Michael wrote:

Partial answer (in the test) about libraries still present in OJ

>> *envoyé :* 16 janvier 2022 à 13:43>> *de :* edgar.sol...@web.de
>> *à :* OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net>
>> *objet :* Re: [JPP-Devel] Fwd: [openjump-gis/openjump] ec1bf8: upgrade cadtools to 2.1.1
>>
>>
>>
>> On 16.01.2022 09:44, Michaud Michael wrote:
>>
>>> Ede,
>>>
>>> Repackaging cadtools fixed the last error happening at OpenJUMP start.
>>>
>> sure. still i wrote you that i am on it ;)
>>
>>> Next big target is probably the OpenJUMP 2 release itself.
>>>
>> let us clean up lib/plus/ before that. can you comment on the lingering
>>
>> ./dbquery.properties
>> ./jaxb <-- to be removed
>>

jaxb is shared by 2 extensions (set-attribute and view-manager). We can let it in the core

or repackage extensions to include it (better, may introduce several version of the dependency

if we don't care)

./jaxb/javax.activation-api-1.2.0.jar
./jaxb/jaxb-api-2.2.12.jar
./jaxb/jaxb-core-2.2.11.jar
./jaxb/jaxb-impl-2.2.11.jar

hmm, imageioext still uses em too.

[INFO] +- it.geosolutions.imageio-ext:imageio-ext-geocore:jar:1.3.11:compile
[INFO] | +- javax.xml.bind:jaxb-api:jar:2.4.0-b180830.0359:compile
[INFO] | \- javax.activation:javax.activation-api:jar:1.2.0:compile

generally i'd like to et rid of them because of Sun proprietary closed code. also the legal distribution somewhat muddy. afaiu you actually should need to download it from their servers everytime you build, while you are allowed to ship it with your distro.

Is it really closed code ? According to maven repo, jaxb is GPL2 (https://mvnrepository.com/artifact/com.sun.xml.bind/jaxb-impl), and new version 3 is EPL (https://github.com/eclipse-ee4j/jaxb-ri) 


would you be willing to look at a replacement for your extensions?

If I find another implementation of the same API with a more flexible license, I can check it, but I'm not ready for a change to a different serialization tool. 


how about we package it to lib/ext/jaxb/ for now. wanna get rid of lib/plus/ ;)

No problem, 

./jumpdbquery-1.1.1./jumpdbquery-1.1.1/CONTRIBUTORS.txt
./jumpdbquery-1.1.1/COPYING
./jumpdbquery-1.1.1/gt2-oracle-spatial-2.3.2.jar
./jumpdbquery-1.1.1/jsyntaxpane-1.0.0.jar
./jumpdbquery-1.1.1/LICENSE.txt
./jumpdbquery-1.1.1/NOTICE.txt
./jumpdbquery-1.1.1/postgis-jdbc-1.3.3.jar
./jumpdbquery-1.1.1/README_jumpdbquery.txt
./jumpdbquery-1.1.1/README_releases.txt
./jumpdbquery.jar

read your mail and Jukka's answer. i'd agree to the empty geometry issue. also it'd surely make sense allow editing the query in the wizard already. if we had both we probably are close enough to Dbquery extension to drop it i'd say.

There are two modes to query a database from the CORE : AddDataStoreLayer and RunDataStoreQuery.

I think it makes more sense and maybe it is easier to add the capability to add a non spatial layer from the second

because the former is more closely related to spatial characteristics of tables.

Anyway, there is a bit of work to get it right, but as long as there is a workaround, I would not worry too much about the dbquery plugin.  

./lib./lib/text-utils-1.0.1.jar <-- to be removed

OK, let's remove it. Just used by a personal plugin which is not included in PLUS.


./oj_osm_reader_v1-0-4
./pbaseClasses
./PirolCsv

what about the above? you marked Osm driver as unmaintained, so we'll drop it? remove pbaseClasses/PirolCsv as well?

OSM : it is from Stefan. I have hoped that maybe he would volunteer to port it. If not, source code is available in sourceforge and we could probably migrate. 

PirolCsv : this sone can be abandonned as I rewrote a csv plugin which, I think, is more capable.

pbaseClasses: I'm not 100% sure that no code use it in CORE, as Pirol has done many contribution in the past, but we can try to remve it and see. 

./set_attributes <-- needed by extension?
Resources to be included in extension, not in the core, I will do it


./set_attributes/DocumentedSample.xml
./set_attributes/img
./set_attributes/img/331.png
SNIP
./set_attributes/maxspeed.xml
./table-layout-4.3.0.jar <-- will be removed

Can't remember where it is used...


./wfs <-- no source, no extension or?

Source in sourceforge. I did not migrate it to github because I think there is more than a migration to do

(depends on an old version of deegree which is no more compatible with new JTS I think)


./wfs/commons-httpclient-3.1
./wfs/deegree2-core-2.6-pre2-20140511.220246-596
./wfs/jaxen-1.1.1
./wfs/vecmath-1.5.2
./xbean-2.2.0

Don't know what xbean is for

etc/Readme.txt says
"
TableLayout-*.jar - Clearthought License - clearthought-2.0.txt
xbean-*.jar - Apache License Version 2.0 - apache_license-2.0.txt
"

TableLayout seems to be used by Sextante


let's remove it and readd it to the extensions that need it

>>> Before that, I will make more tests, update dependencies where possible (ex. postgresql)
>>>
>>> and report anything I find through github issues, so that we can coordinate more easily.
>>>
>>> Just read that log4j 1 has a problem since java9 (https://blogs.apache.org/logging/entry/moving_on_to_log4j_2) <https://blogs.apache.org/logging/entry/moving_on_to_log4j_2)>
>>> Any hint about this ?
>>>
>> never noticed anything. is something broken because of it? if no, no reason to jumo in squares ;).. ede
>>
>> ps. just ran with java9.0.4. logging worked as expected.
>>

OK, fine,

sunny regards ..ede

_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to