[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218792#comment-13218792 ]
Neha Narkhede commented on KAFKA-290: ------------------------------------- There is another place where it will be worthwhile to use propertyExists instead of a non-null check - if(brokerList != null && Utils.getString(props, "partitioner.class", null) != null) throw new InvalidConfigException("partitioner.class cannot be used when broker.list is set") > use propertyExists to test if both broker.list and zk.connect are present > ------------------------------------------------------------------------- > > Key: KAFKA-290 > URL: https://issues.apache.org/jira/browse/KAFKA-290 > Project: Kafka > Issue Type: Improvement > Affects Versions: 0.7.1 > Reporter: Jun Rao > Assignee: Jun Rao > Attachments: kafka-290.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira