[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419663#comment-13419663 ]
Joel Koshy commented on KAFKA-404: ---------------------------------- Sorry I didn't get a chance to look at this sooner. Thanks for making the changes. Re: using vals, in this case we don't need any vars and I think it will be clearer if we just use substring instead of splitting zkconnect and reconstructing path out of that. So something like this, but I haven't checked: if (zkConnect.contains('/')) { val sepIndex = zkConnect.indexOf('/') val connect = zkConnect.substring(0, sepIndex) val path = zkConnect.substring(sepIndex) ... > When using chroot path, create chroot on startup if it doesn't exist > -------------------------------------------------------------------- > > Key: KAFKA-404 > URL: https://issues.apache.org/jira/browse/KAFKA-404 > Project: Kafka > Issue Type: Improvement > Affects Versions: 0.7.1 > Environment: CentOS 5.5, Linux 2.6.18-194.32.1.el5 x86_64 GNU/Linux > Reporter: Jonathan Creasy > Labels: newbie, patch > Fix For: 0.8 > > Attachments: KAFKA-404-0.7.1.patch, KAFKA-404-0.8.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira