[ 
https://issues.apache.org/jira/browse/KAFKA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420756#comment-13420756
 ] 

Jay Kreps commented on KAFKA-350:
---------------------------------

1.1, 1.2, 2.1, 2.2 Awesome!

2.3 Hmm, well so but that doesn't make sense because we would always pop the 
socket timeout and fully close out the connection, which is not good. Basically 
the socket timeout would ALWAYS go off before the server-side request 
processing timeout due to the network latency both ways. I think that timeout 
should just be for "emergencies". I agree it is a bit of a muddle now that we 
have two.

7.2 Hmm, but that changed ALL IllegalStateExceptions to KafkaException. 
IllegalStateException is used to say "this should not be possible". For example 
in SocketServer those checks are in the form of assertions. I like the idea of 
KafkaException, and I think we should make all the other exceptions extend it 
to ease error handling on the client, but I don't think we should get rid of 
IllegalStateException or IllegalArgumentException, they are informative.

                
> Enable message replication in the presence of controlled failures
> -----------------------------------------------------------------
>
>                 Key: KAFKA-350
>                 URL: https://issues.apache.org/jira/browse/KAFKA-350
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>         Attachments: kafka-350-v1.patch, kafka-350-v2.patch
>
>
> KAFKA-46 introduced message replication feature in the absence of server 
> failures. This JIRA will improve the log recovery logic and fix other bugs to 
> enable message replication to happen in the presence of controlled server 
> failures

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to