[ https://issues.apache.org/jira/browse/KAFKA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421590#comment-13421590 ]
Jun Rao commented on KAFKA-350: ------------------------------- Thanks for patch v4. We are almost there. 21. In partitionAndCollate(), UnknownTopicException doesn't seem to recoverable. 30. It doesn't look like the broker handles requestTimeoutMs of 0 through RequestPurgatory. It's probably simpler if we just require timeout to be positive. If someone wants infinite timeout, MAX_INT can be used instead. If those issues are addressed, the patch can be committed without another round of review. 34. This seems to only happen on my laptop. Will file another jira. > Enable message replication in the presence of controlled failures > ----------------------------------------------------------------- > > Key: KAFKA-350 > URL: https://issues.apache.org/jira/browse/KAFKA-350 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Neha Narkhede > Assignee: Neha Narkhede > Attachments: kafka-350-v1.patch, kafka-350-v2.patch, > kafka-350-v3.patch, kafka-350-v4.patch > > > KAFKA-46 introduced message replication feature in the absence of server > failures. This JIRA will improve the log recovery logic and fix other bugs to > enable message replication to happen in the presence of controlled server > failures -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira