[
https://issues.apache.org/jira/browse/KAFKA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473350#comment-13473350
]
Neha Narkhede commented on KAFKA-510:
-------------------------------------
Thanks for patch v7, here are few review comments -
1. ControllerChannelManager
Probably better to change partitionInfo to partitionState.
2. KafkaApis
2.1. Wrap the line that computes the partitions with replication factor 1
2.2. Rename allPartitionHasReplicationFactorOne to
allPartitionsHaveReplicationFactorOne
2.3. Change the if(partitionOpt.isDefined) to case match.
3. LeaderAndIsrRequest
3.1 Add a space between closing parenthesis and opening bracket for case class
definition of LeaderAndIsr
3.2 Rename partitionInfos to partitionState
3.3 Rename PartitionInfo to PartitionState
4. ReplicaManager
4.1 Remove unused import
4.2 Change if(partitionOpt.isDefined) to case match
4.3 Why is the following check required in the absence of a feature that allows
us to change the replication factor of a partition -
if(partition.replicationFactor != replicationFactor)
partition.replicationFactor = replicationFactor
4.4 Rename partitionInfos to partitionState
5. ReplicaStateMachine
5.1 Wrap the long lines
> broker needs to know the replication factor per partition
> ---------------------------------------------------------
>
> Key: KAFKA-510
> URL: https://issues.apache.org/jira/browse/KAFKA-510
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Yang Ye
> Priority: Blocker
> Labels: bugs
> Fix For: 0.8
>
> Attachments: kafka_510_v1.diff, kafka_510_v2.diff, kafka_510_v3.diff,
> kafka_510_v4.diff, kafka_510_v5.diff, kafka_510_v6.diff, kafka_510_v7.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> A broker needs to know the replication factor to report under replicated
> partitions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
