https://bugs.kde.org/show_bug.cgi?id=339863

Wolfgang Bauer <wba...@tmo.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wba...@tmo.at

--- Comment #50 from Wolfgang Bauer <wba...@tmo.at> ---
(In reply to David M from comment #49)
> I'm happy to report that with the Breeze theme, KDE Applications 16.04
> finally it appears for whatever reason that this bug is fixed and all star
> ratings now appear as they should. 

Actually, with breeze this is fixed since months. If it didn't work for you,
you probably experienced a different problem, maybe this one:
https://bugzilla.opensuse.org/show_bug.cgi?id=970896, which is indeed fixed in
dolphin 16.04.

But the rating display is still completely broken with other themes (including
oxygen) that don't provide a "rating-unrated" icon.

The reason is as suggested in comment#20:
(In reply to Christoph Feck from comment #20)
> I guess this has something to do with the KDE icon loader
> stating that "rating-unrated" icon exists, but actually only found the
> fallback icon "rating". The Qt icon loader seems to handle this correctly.

But, this is not a bug in the icon loader I think, that's how the behaviour is
defined in the freedesktop icon name specification
(https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines):
The dash “-” character is used to separate levels of specificity in icon names,
for all contexts other than MimeTypes. For instance, we use “input-mouse” as
the generic item for all mouse devices, and we use “input-mouse-usb” for a USB
mouse device. However, if the more specific item does not exist in the current
theme, and does exist in a parent theme, the generic icon from the current
theme is preferred, in order to keep consistent style.

That implies that if "rating-unrated" doesn't exist in the current theme,
"rating" (from the current theme) should be used instead.
So "rating-unrated" was actually a bad choice to begin with I think, and can't
really work as intended IMHO.

But what about the most obvious and probably easiest "solution"?
Just add a "rating-unrated" icon to the oxygen theme.
That should fix the problem also for other themes, as oxygen is still used as
fallback for missing icons in the currently configured icon theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to