On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid <tsdg...@terra.es> wrote:
> This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102179/ > > On August 4th, 2011, 3:19 a.m., *Dawit Alemayehu* wrote: > > I do not like this patch for the very reason you stated. I do not want the > mutex there either because it is rather expensive. As it stands we start a > thread for each lookup right now which in of itself is already too expensive > for my taste. Hence, I will have to think of some other way to avoid the even > worse solution of creating a local even loop. > > Having said that, are you using a slow DNS server ? The only way the lookup > thread gets terminated is if your nameserver takes longer than 1000 ms per > query. That is because the two KUriFilterPlugins that use it set a timeout > value of that duration. Otherwise, that code path should not be encountered > at all! > > So you do not want a patch that fixes konqueror crashing 75% times i use it > in exchange of having a small memory leak once in a blue moon? Awesome. > > Did I say I do not want the patch ?? All I said was need to think of a better way to fix this patch! Clam down.
