-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102822/
-----------------------------------------------------------
Review request for kdelibs, Andreas Hartmetz and Dawit Alemayehu.
Description
-------
Keep-alive header can specify multiple, comma-separated, value pairs.
For example what apache web server normally sends is something like that:
"Keep-Alive: timeout=5, max=99"
Actually kio_http fails to extract timeout value because it assumes
keep-alive header can contain only a single value pair.
In the case of example above what it end up to do is
m_request.keepAliveTimeout = QString("5, max=99").toInt(), that returns 0
(wrong!).
Diffs
-----
kioslave/http/http.cpp 2862707
kioslave/http/parsinghelpers.cpp fc75d68
Diff: http://git.reviewboard.kde.org/r/102822/diff/diff
Testing
-------
-Patched code compiles
-Hacked a web server and made tests against following keep-alive header
variants:
"Keep-Alive: timeout=5, max=99"
"Keep-Alive: Timeout=5, max=99" (uppercase 'T')
"Keep-Alive: Timeout=5 , max=99" (extra space before comma)
Thanks,
Andrea Iacovitti
