On Thursday 17 November 2011 13:33:25 David Faure wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103165/#review8264 > ----------------------------------------------------------- > > > > kutils/kpluginselector.cpp > <http://git.reviewboard.kde.org/r/103165/#comment7070>
Grmmbl, something's broken in konqueror/webkit/khtml/kio, my comment got lost, three times in a row. Let's use email instead... You changed the results, operator ?: has precedence over +. And clearly this is what was intended, otherwise the "0 +" wouldn't be there. So this should be ( showIcon ? SizeMedium : 0 ) + margin * i + buttonWidth * j. Not sure why clang warns anyway, since the operator precedence is clear, but I guess it's like the gcc warning about a || b && c (idiot-proof-ness). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
