----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8271 -----------------------------------------------------------
Ship it! Ah, no, you're right, I read 'man operator' wrong. + does have precedence over ?:, so the code was wrong, and your fix fixes an actual bug. Yay for compiling the same code with different compilers! - David Faure On Nov. 17, 2011, 2:37 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103165/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 2:37 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Trivial c++ fixes for some warnings of clang++ (2.99.9999) > memset the structure size, not the pointer size (fortunately, the structure > size is greater than pointer size in this case). > remove double parenthesis > change false to 0 as pointer parameter > use parenthesis to clarify preference between ? and + > > > Diffs > ----- > > kdecore/sycoca/kmemfile.cpp a466bde > kdeui/fonts/kfontchooser.cpp 541f7db > kdeui/tests/ktabwidgettest.cpp fdc3161 > kross/modules/form.cpp 5e260c1 > kutils/kemoticons/kemoticonstheme.cpp c145741 > kutils/kpluginselector.cpp 0a39fcc > > Diff: http://git.reviewboard.kde.org/r/103165/diff/diff > > > Testing > ------- > > Still compiles with g++ > > > Thanks, > > Jaime Torres Amate > >
