> On Jan. 4, 2012, 4:58 p.m., Christoph Feck wrote: > > ksmserver/themes/default/main.qml, line 166 > > <http://git.reviewboard.kde.org/r/103621/diff/1-2/?file=45373#file45373line166> > > > > Note that pointSize != pixelSize. With a high DPI display, a 10 pt font > > could be 30 pixels large, but if you set it to 9 pixels (10 * 0.9), then it > > will be unreadably small. > > > > Also I am not sure I understand the comment "pixelSize does not work" > > correctly. The idea is to have the buttons be as big as neccessary for the > > selected font. > > > > As far as I know, Martin Gräßlin had to add some QML code to get the > > "actual" pixel size of texts just to make the layout font size adaptive, > > but maybe in newer versions, the layout uses size hints automatically. > > Could you add him as a reviewer?
That explains why the font is always smaller than the rest of the desktop. I should have used only pointSize, not pixelSize. Now it works, thanks. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9537 ----------------------------------------------------------- On Jan. 4, 2012, 5:03 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103621/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2012, 5:03 p.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Description > ------- > > Port the shutdown dialog to QML. Two QML themes are included: default, which > mimics the current shutdown dialog look & fell, and countour, which is used > in Plasma Active. > > > Diffs > ----- > > ksmserver/shutdowndlg.cpp a09a1a7 > ksmserver/shutdowndlg.h e5f0942 > ksmserver/shutdown.cpp 7fd1e11 > ksmserver/CMakeLists.txt 295b96e > ksmserver/themes/contour/ContourButton.qml PRE-CREATION > ksmserver/themes/contour/main.qml PRE-CREATION > ksmserver/themes/contour/metadata.desktop PRE-CREATION > ksmserver/themes/contour/screenshot.png PRE-CREATION > ksmserver/themes/default/ContextMenu.qml PRE-CREATION > ksmserver/themes/default/KSMButton.qml PRE-CREATION > ksmserver/themes/default/MenuItem.qml PRE-CREATION > ksmserver/themes/default/main.qml PRE-CREATION > ksmserver/themes/default/metadata.desktop PRE-CREATION > ksmserver/themes/default/screenshot.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103621/diff/diff > > > Testing > ------- > > Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work > in 4.7.x because the patch requires kde-runtime 4.8's declarative imports. > > There is still one bug left: keyboard nagivation works with TAB, BACKSPACE, > and arrow-keys, but only the TAB key works at first. You always have to press > the TAB key at least once for the other keys to work for navigation. The > first TAB press only activates the navigation, you still need a second press > to actually move focus to the next element. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/103621/s/400/ > > > Thanks, > > Lamarque Vieira Souza > >
