----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/#review32362 -----------------------------------------------------------
Ship it! Looks good, please commit. I just wrote a unittest for it, which I'll commit next. - David Faure On May 11, 2013, 8:43 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110392/ > ----------------------------------------------------------- > > (Updated May 11, 2013, 8:43 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > The attached patch fixes KTar so that the contents of a sample archive: > > d/ > d/f1.txt > d/ > d/f2.txt > > are shown correctly as > > d/f1.txt > d/f2.txt > > instead of > > d/f2.txt > > See the bug report for details on what kind of archives are not shown > correctly in Konqueror vs Ark. > > > This addresses bug 206994. > http://bugs.kde.org/show_bug.cgi?id=206994 > > > Diffs > ----- > > kdecore/io/ktar.cpp 142a80a > > Diff: http://git.reviewboard.kde.org/r/110392/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
