> On May 6, 2013, 11:49 a.m., Kevin Ottens wrote: > > My knowledge of the changes in the MMX/SSE landscape are slightly too > > limited for me to be 100% sure. But it looks like a fine patch.
I just at that patch again, and I just realized that I changed the flags for Linux too, so it might change some stuff there too. Did you actually look at this stuff, and can you check if this gives you SSE4.2 e.g. (probably on your computer available). - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review32127 ----------------------------------------------------------- On Feb. 8, 2013, 1:09 a.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108845/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 1:09 a.m.) > > > Review request for KDE Frameworks, kdelibs and Patrick von Reth. > > > Description > ------- > > This change implements cpu feature checks for MSVC. While at it, I added > support SSSE3 and SSE4.2 to the InstructionSets. I took the new values from > http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits . > > > Diffs > ----- > > tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 > tier1/solid/src/solid/processor.h ce4f0e1 > > Diff: http://git.reviewboard.kde.org/r/108845/diff/ > > > Testing > ------- > > Windows > > > Thanks, > > Patrick Spendrin > >