----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127138/ -----------------------------------------------------------
Review request for KDE Base Apps and David Faure. Repository: kde-baseapps Description ------- This happens when a local file URL which ends in "/" is navigated to. For example, going to "/home/user" correctly shows "user" as the window title, while going to "/home/user/" shows "/" because the fileName() of that URL is empty. This happens in particular when using the "Up" action, as it goes from "/home/user/foo" to "/home/user/". This change ensures that trailing slashes are removed from URLs before using fileName() on them. Diffs ----- konqueror/src/konqview.cpp 3707c7a Diff: https://git.reviewboard.kde.org/r/127138/diff/ Testing ------- Built kde-baseapps with these changes, observed correct display of base name in Konqueror window title while navigating. Thanks, Jonathan Marten