bruns added inline comments. INLINE COMMENTS
> bruns wrote in jobtest.cpp:487 > this obviously needs test cases with a key ley/value len > 512, to check the > the array-to-short/resize path. not done ... > file_unix.cpp:620 > +#endif > + qDebug(KIO_FILE) << valuelen << " " << key << " " << value; > + if (valuelen > 0 && value.size() == 0) { No extra spaces for qDebug, inserts spaces itself. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh