-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125707/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 7:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kdenlive and Vincent Pinon.


Changes
-------

Submitted with commit d0ca82c01c9c12c76f110bb654a3fef7aff181b5 by Vincent Pinon 
on behalf of Harald Albrecht to branch Applications/15.08.


Repository: kdenlive


Description
-------

Class Timeline incorrectly checks the bounds for track indices: the upper bound 
is checked against greater than track.count(), where in fact the indices run 
from 0 to count-1.

However, this masks the underlying problem with converted Kdenlive projects: 
when adding new tracks, the index gets out of bounds, so this needs to be fixed 
too. This patch just fixes the crash in itself but not the underlying problem 
of handing in an out-of-bounds index to these functions to be fixed.


Diffs
-----

  src/timeline/timeline.cpp fb5bf90 

Diff: https://git.reviewboard.kde.org/r/125707/diff/


Testing
-------

Tested against recent Kdenlive branch Applications/15.08, on Kubuntu 15.04 
64bit system. Tested with a converted 15.04 Kdenlive project that exhibits this 
bug when trying to add new tracks to the timeline.


Thanks,

The DiveO

_______________________________________________
kdenlive mailing list
kdenlive@kde.org
https://mail.kde.org/mailman/listinfo/kdenlive

Reply via email to