https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018
David Cook <dc...@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from David Cook <dc...@prosentient.com.au> --- When reviewing the change... 1. When reviewing, there should be no new reference to libio-socket-ip-perl, since we don't have that in the cpanfile and IO::Socket::IP is already part of perl-base. So that's good. 2. With this patch, libcpan-meta-perl now appears in debian/control without any reference to version number of "perl-modules", and this is potentially a problem... because CPAN::Meta 2.150010 is part of the perl core (via perl-modules-5.XX) since Perl 5.14 (AKA Debian 7 Wheezy). So... if we accidentally installed libcpan-meta-perl it's probably not a big deal, because it's the same version as the core version. One of them would appear first when searching @INC and it shouldn't really matter. But... we really shouldn't be installing a package (that we host on debian.koha-community.org) if we don't need it. 3. "liblwp-protocol-https-perl" appears instead of "liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl," liblwp-protocol-https-perl is in buster, bullseye, bookworm, etc and we don't have it in the debian.koha-community.org repo. I think this is fine. -- So overall... I think the IO::Socket::IP and LWP::Protocol::https changes are good, but not the the CPAN::Meta one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/