https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38452

Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.r...@rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
Not sure if this change is enough.
Look at following lines:

    my @items = Koha::Items->search( { barcode => { -in => \@barcodes } }
)->as_list;
    my %items = map { $_->barcode => $_ } @items;
    foreach my $barcode (@barcodes) {
        my $item = $items{ $barcode };

$barcode that is looked up in the hash comes from @barcodes which now contains
only lowercase barcodes, right?
But the %items hash comes from a Koha::Items search. The SQL search is case
insensitive and might return uppercase barcodes. Therefore $items{ABC123} does
not exist, resulting in ERR_BARCODE, right?

This shows that your test plan should also cover the ABC123 barcode case.

Did you check if we have similar issues further on in the script?

Please clarify.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to