https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701

Phil Ringnalda <p...@chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175457|0                           |1
        is obsolete|                            |

--- Comment #2 from Phil Ringnalda <p...@chetcolibrary.org> ---
Created attachment 175469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175469&action=edit
Bug 38701: Fix HTML validity errors in invoice template

This patch makes some markup corrections to acqui/invoice.tt so that it
passes an HTML validity check.

- Moves incorrectly placed </td>
- Change <span> to <div> and remove invalid </br>
- Correct instances of "<th class="replacementprice"/>" (th cannot be
  self-closed)
- Add id attribute to inputs to correspond to existing labels
- Change "all_fund_dropdown" markup so that it validates but still works
  with the active/inactive fund display.

To test, apply the patch and go to Acquisitions -> Invoices. Perform an
invoice search which will return results. In the results click the
invoice number to view the invoice.

- Test the "show inactive" checkbox corresponding to the "Shipping fund"
  dropdown. Checking and unchecking it should work correctly to show and
  hide inactive funds.
- Run the page source through https://validator.w3.org and confirm that
  there are no errors coming from this template.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <p...@chetcolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to