https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663
--- Comment #33 from Pedro Amorim <pedro.amo...@ptfs-europe.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #32) > Everything works find and QA tool passes. Implementation is the same as for > other additional fields so it makes sense to me. > > Concerning the code I'm wondering why there is a double if here ? > > > [% IF CAN_user_parameters_manage_libraries %] > > <h3>Admin</h3> > > <ul> > > [% IF CAN_user_parameters_manage_libraries %] > > [% WRAPPER table_option value="branches" > > %]<span>Libraries</span>[% END %] > > [% END %] > > </ul> > > [% END %] > > I also tested other values to verify nothing is broken by record_id type > changes, looks fine. Hey, that's a good observation. I opted for this pattern approach as the initial IF should be an OR of all child IFs. It's just so happens that in this case there is only 1 child IF, but more entries may be added under 'Admin' in the future. To better understand what I mean here see the 'Acquisitions' section of the code right above it. Having said that, this same pattern is not present on the other subsequent IFs below so, yeah, up for discussion. I agree with either way and don't feel strongly about it, but I believe that was the reason. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/