https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651
--- Comment #25 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- (In reply to Nick Clemens (kidclamp) from comment #24) > I am not convinced this is a desired behavior change for all libraries. When > they decided to set the pref, it explicitly said "does not affect" several > things > > Would you be open to a second setting within the pref: > > CircConfirmFutureHolds (at checkin, at renewal, at checkout - multi select?) > starting no later then XX days Hi Nick. Thanks for looking here ! The description "But it does not interfere with issuing, renewing or transferring items" is not the most lucky one. I might have added it myself long ago ;) Note also that we are talking about a feature that say over 90% of the libraries is not using. (HEA: 1040 AllowHoldDateinFuture 728 OPACAllowHoldDateInFuture ) Lets look at the processes mentioned. (When writing this patch, I reviewed all occurrences of current_holds btw.) Checkout AddIssue already calls MoveReserve and that does check ConfirmFutureHolds. So this is an "existing interference". The description was wrong. Renew CanBookBeRenewed calls current_holds. This is a "new interference". If a library allows future holds and wants to confirm them within a few days specified by ConfirmFutureHolds, currently this is ignored by CanBookBeRenewed. So the book is renewed although there is a hold for it on tomorrow. Not sure if we should write code for that? Probably most do not want to renew here. Transfer transferbook calls CheckReserves without lookahead days. So it does not block a transfer for a future hold (when not ignoring them altogether). Feels like a bug to me that could be solved on another report :) So there is currently no interference here. Discussion elsewhere? Checkin This is not relevant here. ConfirmFutureHolds already affects checkin (especially the popup). And this is already advertized accordingly. In conclusion, the new extra preference should only pertain to renewals. This would imo be a rather ugly exception. I would advise against it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
